Skip to content

Conversation

@flaix
Copy link
Member

@flaix flaix commented Oct 21, 2021

Various fixes cleaning up problems with the Wicket resource bundle.

flaix added 6 commits October 21, 2021 21:02
Some property keys were duplicated, mostly `status`, `permission` and
`comment`.
The problem with `gb.comment` is, that it is used in two different
locations in two different meanings. One as a verb, the second as a
noun. Which makes no difference in English, but other languages.
The solution is that the second key is renamed to `gb.sshKeyComment`.
The code is adjusted accordingly.
If keeps acting up when trying to stage parts of it. I hope this fixes that.
Some property keys had typos.
There is a `gb.ticketStatus` and a `gb.ticketState`. Neither is used
anywhere in the code, but only the former is defined in the default file.
So only use `gb.ticketStatus`.
Double escaped backslashes, wrongly escaped unicode codes, broken escaped
newlines.
@flaix flaix added the hacktoberfest-accepted Accepted Hacktoberfest contribution, will merge later. label Oct 21, 2021
@flaix flaix added this to the 1.9.2 milestone Oct 21, 2021
Copy link
Member Author

@flaix flaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a last step, we could transform all properties files to Unix format. But that would disturb the review here a little, if not done commit by commit.

@flaix flaix merged commit 9d297ab into gitblit-org:master Oct 22, 2021
@flaix flaix deleted the fix-resource-bundle branch October 23, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted Hacktoberfest contribution, will merge later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant