ci: add github action workflows #2596

laojianzi · 2020-12-29T08:06:16Z

Trying to solve: #2582

Merge before:

open Setting > Secrets and set you'r gitter room id to GITTER_ROOM_ID
Merge test: fixed the TestUnixSocket test on windows #2595

If the master branch changes, or if a problem occurs that does not necessarily occur, you can choose to re-run the github action job.

Differences from Travis CI:

Multiple os ubuntu-latest, macos-latest, windows-latest
No go master version
Sending gitter notifications using curl

Some of the problems I've encountered since using GitHub Action

TestUnixSocket windows cannot read /tmp/unix_unit_test (fixed: test: fixed the TestUnixSocket test on windows #2595)
TestPathCleanMallocs have a certain chance of failure (I don't know how to repair it 😕 )

path_test.go:85: 
   	Error Trace:	path_test.go:85
   	Error:      	Not equal: 
   	            	expected: float64(2010)
   	            	actual  : int(0)
   	Test:       	TestPathCleanMallocs

TestUnixSocket have a certain chance of failure (I don't know how to repair it 😕 )

Get http://127.0.0.1:49379/test: dial tcp 127.0.0.1:49379: bad file descriptor

codecov · 2021-01-03T15:19:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@61a0cda). Click here to learn what that means.
The diff coverage is 97.99%.

@@            Coverage Diff            @@
##             master    #2596   +/-   ##
=========================================
  Coverage          ?   98.69%           
=========================================
  Files             ?       41           
  Lines             ?     2072           
  Branches          ?        0           
=========================================
  Hits              ?     2045           
  Misses            ?       15           
  Partials          ?       12

Impacted Files	Coverage Δ
binding/msgpack.go	`100.00% <ø> (ø)`
binding/protobuf.go	`100.00% <ø> (ø)`
render/msgpack.go	`100.00% <ø> (ø)`
render/render.go	`100.00% <ø> (ø)`
response_writer.go	`93.33% <33.33%> (ø)`
render/json.go	`85.29% <68.75%> (ø)`
context.go	`97.65% <94.85%> (ø)`
gin.go	`99.18% <98.14%> (ø)`
auth.go	`100.00% <100.00%> (ø)`
binding/binding.go	`100.00% <100.00%> (ø)`
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a0cda...d8f92db. Read the comment docs.

thinkerou · 2021-01-13T17:32:24Z

open Setting > Secrets and set you'r gitter room id to GITTER_ROOM_ID
-- now only @javierprovecho can set it

laojianzi · 2021-01-14T02:12:56Z

open Setting > Secrets and set you'r gitter room id to GITTER_ROOM_ID
-- now only @javierprovecho can set it

gin/.travis.yml

Line 47 in b01605b

- https://webhooks.gitter.im/e/7f95bf605c4d356372f4

@thinkerou Replace GITTER_ROOM_ID with 7f95bf605c4d356372f4, as in .travis.yml.

What do you think?

thinkerou · 2021-01-14T05:07:17Z

open Setting > Secrets and set you'r gitter room id to GITTER_ROOM_ID
-- now only @javierprovecho can set it

gin/.travis.yml

Line 47 in b01605b

- https://webhooks.gitter.im/e/7f95bf605c4d356372f4

@thinkerou Replace GITTER_ROOM_ID with 7f95bf605c4d356372f4, as in .travis.yml.

What do you think?

Yes, OK! thanks.

.github/workflows/gin.yml

laojianzi · 2021-01-15T03:06:36Z

https://github.com/gin-gonic/gin/runs/1706106769?check_suite_focus=true#step:6:32

--- FAIL: TestLoadHTMLFilesDebugMode (0.00s)
make: *** [test] Error 1
    debug_test.go:144: 
        	Error Trace:	debug_test.go:144
        	            				asm_amd64.s:1357
        	Error:      	Received unexpected error:
        	            	read |0: bad file descriptor
        	Test:       	TestLoadHTMLFilesDebugMode

bad file descriptor often occurs, suspected to be related to the use of goroutine in testing (speculation without any evidence)

thinkerou

lgtm, thanks!

thinkerou · 2021-01-15T06:00:39Z

@appleboy please review the pr, thanks!

continuous-integration/travis-ci Expected — Waiting for status to be reported
why still required?

laojianzi · 2021-01-15T06:39:55Z

@thinkerou Maybe it has something to do with this, only @javierprovecho can set it?

laojianzi · 2021-01-15T06:48:56Z

gin/.github/PULL_REQUEST_TEMPLATE.md

Line 4 in 540b1ef

    
           - It should pass all tests in the available continuous integration systems such as TravisCI.

gin/CONTRIBUTING.md

Line 11 in 540b1ef

    
           - It should pass all tests in the available continuous integration systems such as TravisCI.

gin/README.md

Line 5 in 46ddd42

    
           [![Build Status](https://travis-ci.org/gin-gonic/gin.svg)](https://travis-ci.org/gin-gonic/gin)

@thinkerou I think these need to be replaced with GitHub Action, do they need to be updated here?

thinkerou · 2021-01-15T07:24:40Z

gin/.github/PULL_REQUEST_TEMPLATE.md

Line 4 in 540b1ef

- It should pass all tests in the available continuous integration systems such as TravisCI.

gin/CONTRIBUTING.md

Line 11 in 540b1ef

- It should pass all tests in the available continuous integration systems such as TravisCI.

gin/README.md

Line 5 in 46ddd42

[![Build Status](https://travis-ci.org/gin-gonic/gin.svg)](https://travis-ci.org/gin-gonic/gin)

@thinkerou I think these need to be replaced with GitHub Action, do they need to be updated here?

yes, please update, thanks!

laojianzi · 2021-03-27T09:47:18Z

Thank

@appleboy add go version 1.16 to ci and fixed the conflicts
@thinkerou I didn't think it was necessary to keep .travis.yml after using github actions, so I deleted it

Please review again

thinkerou · 2021-03-27T10:38:59Z

Thank

@appleboy add go version 1.16 to ci and fixed the conflicts
@thinkerou I didn't think it was necessary to keep .travis.yml after using github actions, so I deleted it

Please review again

ok, thanks!
wait @javierprovecho solve this: continuous-integration/travis-ci Expected — Waiting for status to be reported

appleboy · 2021-04-06T02:50:29Z

@thinkerou Move the PR to v1.8 milestone?

thinkerou · 2021-04-06T02:52:54Z

@thinkerou Move the PR to v1.8 milestone?

OK, merge to marster before removing continuous-integration/travis-ci Expected — Waiting for status to be reported

thinkerou · 2021-06-22T22:41:17Z

@laojianzi please fix conflict and we will merge it, thanks!

laojianzi · 2021-06-23T02:56:09Z

@thinkerou @appleboy https://golang.org/pkg/net/#pkg-note-BUG

Should tests requiring fd be skipped when run in windows?

appleboy · 2021-06-23T03:15:29Z

@laojianzi We can skip the windows testing first and maybe create another PR to track the testing on Windows.

.github/workflows/gin.yml

appleboy · 2021-06-23T03:50:24Z

Waiting for @thinkerou approval.

thinkerou

lgtm, thanks a lot!

…2751) * Update tree.go (#2659) delete more "()" * updated comments for Get function for params (#2756) * ci: add github action workflows (#2596) * ci: add github action workflows * test: fixed the TestUnixSocket test on windows (#20) * ci: add github action workflows (#18) * Remove .travis.yml * ci: replace GITTER_ROOM_ID and upload coverage every time you go test * ci: update coverage using codecov/codecov-action@v1 * Merge branch 'master' into github-actions * repo: replace travis ci to github actions * ci: add go version 1.16 * fix: go install requires a specific version * chore(ci): remove go 1.12 support * chore(ci): remove os windows-latest Co-authored-by: thinkerou <[email protected]> Co-authored-by: Bo-Yi Wu <[email protected]> * Setting trusted platform using an enum-like (#2739) * gin.Context with fallback value from c.Request.Context() * add test case Co-authored-by: youzeliang <[email protected]> Co-authored-by: Ashwani <[email protected]> Co-authored-by: Jeff <[email protected]> Co-authored-by: thinkerou <[email protected]> Co-authored-by: Bo-Yi Wu <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>

* ci: add github action workflows * test: fixed the TestUnixSocket test on windows (#20) * ci: add github action workflows (#18) * Remove .travis.yml * ci: replace GITTER_ROOM_ID and upload coverage every time you go test * ci: update coverage using codecov/codecov-action@v1 * Merge branch 'master' into github-actions * repo: replace travis ci to github actions * ci: add go version 1.16 * fix: go install requires a specific version * chore(ci): remove go 1.12 support * chore(ci): remove os windows-latest Co-authored-by: thinkerou <[email protected]> Co-authored-by: Bo-Yi Wu <[email protected]>

laojianzi and others added 4 commits December 29, 2020 14:23

ci: add github action workflows

0e62d08

test: fixed the TestUnixSocket test on windows (#20)

1a0ef67

ci: add github action workflows (#18)

dacaaac

Merge branch 'master' into github-actions

7142c9b

thinkerou added this to the v1.8 milestone Jan 11, 2021

thinkerou requested review from appleboy and thinkerou January 11, 2021 01:06

thinkerou added the test label Jan 11, 2021

Merge branch 'master' into github-actions

d772d9c

thinkerou reviewed Jan 14, 2021

View reviewed changes

.github/workflows/gin.yml Outdated Show resolved Hide resolved

laojianzi added 3 commits January 15, 2021 10:17

Remove .travis.yml

f6397ee

ci: replace GITTER_ROOM_ID and upload coverage every time you go test

1fe189c

ci: update coverage using codecov/codecov-action@v1

ae84288

Merge branch 'master' into github-actions

3d65cdd

laojianzi force-pushed the github-actions branch from a0687a5 to 3d65cdd Compare January 15, 2021 03:35

Merge branch 'master' into github-actions

ec6888f

thinkerou modified the milestones: v1.8, 1.7 Jan 15, 2021

thinkerou self-requested a review January 15, 2021 05:58

thinkerou previously approved these changes Jan 15, 2021

View reviewed changes

repo: replace travis ci to github actions

e1d5247

laojianzi added 3 commits March 27, 2021 16:35

Merge branch 'gin-gonic-master' into github-actions

ac5241f

ci: add go version 1.16

f71ddcb

fix: go install requires a specific version

02d889a

laojianzi force-pushed the github-actions branch from fee2f9e to 02d889a Compare March 27, 2021 09:33

laojianzi requested a review from appleboy March 27, 2021 09:47

appleboy previously approved these changes Apr 6, 2021

View reviewed changes

Merge branch 'master' into github-actions

2fdd344

thinkerou modified the milestones: 1.7, v1.8 Apr 6, 2021

Merge remote-tracking branch 'upstream/master' into github-actions

d8b87a3

laojianzi dismissed appleboy’s stale review via d8b87a3 June 23, 2021 01:39

chore(ci): remove go 1.12 support

9ad4768

appleboy reviewed Jun 23, 2021

View reviewed changes

.github/workflows/gin.yml Outdated Show resolved Hide resolved

chore(ci): remove os windows-latest

d8f92db

laojianzi force-pushed the github-actions branch from 9debd81 to d8f92db Compare June 23, 2021 03:38

appleboy approved these changes Jun 23, 2021

View reviewed changes

thinkerou approved these changes Jun 23, 2021

View reviewed changes

thinkerou merged commit fb8a113 into gin-gonic:master Jun 23, 2021

t0rchwo0d mentioned this pull request Feb 16, 2023

Add escape logic for header #3500

Merged

a-h mentioned this pull request Nov 16, 2023

golang.org/x/net < 0.17.0 security vulnerability #3755

Closed

ci: add github action workflows #2596

ci: add github action workflows #2596

Uh oh!

Conversation

laojianzi commented Dec 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Some of the problems I've encountered since using GitHub Action

Uh oh!

codecov bot commented Jan 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thinkerou commented Jan 13, 2021

Uh oh!

laojianzi commented Jan 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thinkerou commented Jan 14, 2021

Uh oh!

Uh oh!

laojianzi commented Jan 15, 2021

Uh oh!

thinkerou left a comment

Choose a reason for hiding this comment

Uh oh!

thinkerou commented Jan 15, 2021

Uh oh!

laojianzi commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laojianzi commented Jan 15, 2021

Uh oh!

thinkerou commented Jan 15, 2021

Uh oh!

laojianzi commented Mar 27, 2021

Uh oh!

thinkerou commented Mar 27, 2021

Uh oh!

appleboy commented Apr 6, 2021

Uh oh!

thinkerou commented Apr 6, 2021

Uh oh!

thinkerou commented Jun 22, 2021

Uh oh!

laojianzi commented Jun 23, 2021

Uh oh!

appleboy commented Jun 23, 2021

Uh oh!

Uh oh!

appleboy commented Jun 23, 2021

Uh oh!

thinkerou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

laojianzi commented Dec 29, 2020 •

edited

Loading

codecov bot commented Jan 3, 2021 •

edited

Loading

laojianzi commented Jan 14, 2021 •

edited

Loading

laojianzi commented Jan 15, 2021 •

edited

Loading