Skip to content

fix: convert_hf_to_gguf - change Jamba non-sentencepiece mode (tokeni… #16470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2025
Merged

fix: convert_hf_to_gguf - change Jamba non-sentencepiece mode (tokeni… #16470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8866568
fix: convert_hf_to_gguf - change Jamba non-sentencepiece mode (tokeni…
amirai21 Oct 8, 2025
ef3f884
fix: convert_hf_to_gguf - jamba non-sentencepiece tokenizer to use _s…
amirai21 Oct 11, 2025
1862ab8
fix: convert_hf_to_gguf - removed get_vocab_base_pre from jamba
amirai21 Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions convert_hf_to_gguf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5912,20 +5912,12 @@ def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iter
class JambaModel(TextModel):
model_arch = gguf.MODEL_ARCH.JAMBA

def get_vocab_base_pre(self, tokenizer) -> str:
del tokenizer # unused

return "gpt-2"

def set_vocab(self):
if (self.dir_model / "tokenizer.model").is_file():
# Using Jamba's tokenizer.json causes errors on model load
# (something about "byte not found in vocab"),
# but there's a working tokenizer.model
self._set_vocab_sentencepiece()
else:
# Some Jamba models only have a tokenizer.json, which works.
self._set_vocab_gpt2()
self._set_vocab_llama_hf()
self.gguf_writer.add_add_space_prefix(False)

def set_gguf_parameters(self):
d_model = self.find_hparam(["hidden_size", "mamba_d_model"])
Expand Down