Skip to content

CANN: Add fused FFN op #15209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CANN: Add fused FFN op #15209

wants to merge 1 commit into from

Conversation

hipudding
Copy link
Collaborator

Make sure to read the contributing guidelines before submitting a PR

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning Ascend NPU issues specific to Ascend NPUs labels Aug 10, 2025
@hipudding hipudding changed the title CANN: add fused ffn op CANN: Add fused FFN op Aug 10, 2025
@ggerganov
Copy link
Member

The recommended way for fusing ops is to implement the fusion in the backends. For example:

Adding fused ops in the ggml API will not work because the amount of code will grow exponentially and will not be possible to maintain.

@hipudding
Copy link
Collaborator Author

The recommended way for fusing ops is to implement the fusion in the backends. For example:

Adding fused ops in the ggml API will not work because the amount of code will grow exponentially and will not be possible to maintain.

Got it, Thanks.

@hipudding hipudding closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CISC CISC Awaiting requested review from CISC CISC will be requested when the pull request is marked ready for review CISC is a code owner

@ggerganov ggerganov Awaiting requested review from ggerganov ggerganov will be requested when the pull request is marked ready for review ggerganov is a code owner

@slaren slaren Awaiting requested review from slaren slaren will be requested when the pull request is marked ready for review slaren is a code owner

Assignees
No one assigned
Labels
Ascend NPU issues specific to Ascend NPUs ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hipudding @ggerganov