arg : clean up handling --mmproj with -hf #13082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2cac8e0.
ggerganov
approved these changes
Apr 24, 2025
|
One more case that need to be handled: if the example not using mmproj like |
8 tasks
pockers21
pushed a commit
to pockers21/llama.cpp
that referenced
this pull request
Apr 28, 2025
* arg : clean up handling --mmproj with -hf * rm change about no_mmproj * Revert "rm change about no_mmproj" This reverts commit 2cac8e0. * handle no_mmproj explicitly * skip download mmproj on examples not using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is a bit hacky, so the CI on #12898 is currently broken.
The idea is:
-hfis specified, we ask HF backend where the file is.The backend will response with
auto_detected.ggufFileand optionallyauto_detected.mmprojFileauto_detected.mmprojFileis returned by HF backend:mmprojfile is not set, we use itmmproj.pathormmproj.url