Skip to content

vulkan: sort shaders for more deterministic binary #11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

vulkan: sort shaders for more deterministic binary #11315

merged 1 commit into from
Jan 23, 2025

Conversation

@jeffbolznv
Copy link
Collaborator

@jeffbolznv jeffbolznv commented Jan 20, 2025

Fixes #11306.

@jeffbolznv jeffbolznv requested a review from 0cc4m January 20, 2025 16:35
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jan 20, 2025
@jeffbolznv jeffbolznv mentioned this pull request Jan 20, 2025
Closed
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Jan 20, 2025

Thanks for the quick fix. In a test I found that it fixes the issue, but there is something else remaining, that I will analyze tomorrow and report separately.

@bmwiedemann bmwiedemann mentioned this pull request Jan 20, 2025
Closed
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Jan 22, 2025

Can this PR be merged?
The other issue is tracked in #11317.

@0cc4m
Copy link
Collaborator

0cc4m commented Jan 22, 2025

I'll test it soon and merge if everything looks fine.

0cc4m
0cc4m approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@0cc4m 0cc4m merged commit 1971adf into ggml-org:master Jan 23, 2025
45 checks passed
anagri pushed a commit to BodhiSearch/llama.cpp that referenced this pull request Jan 26, 2025
@jeffbolznv @anagri
vulkan: sort shaders for more deterministic binary (ggml-org#11315)
7f26ad6 
Fixes ggml-org#11306.
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@jeffbolznv @tinglou
vulkan: sort shaders for more deterministic binary (ggml-org#11315)
985606f 
Fixes ggml-org#11306.
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@jeffbolznv @NeoZhangJianyu
vulkan: sort shaders for more deterministic binary (ggml-org#11315)
779d3ef 
Fixes ggml-org#11306.
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@jeffbolznv @mglambda
vulkan: sort shaders for more deterministic binary (ggml-org#11315)
12e98f6 
Fixes ggml-org#11306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

@0cc4m 0cc4m 0cc4m approved these changes

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compile bug: libggml-vulkan.so reproducible builds issue

4 participants

@jeffbolznv @bmwiedemann @0cc4m @ggerganov