Fix multi-layer copies #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
855: Remove comment about `Vec::remove_item` r=kvark a=Pat-Lafon Sadly, `Vec::remove_item` was an unstable method that was deprecated and has now been removed. rust-lang/rust#80972 This pr removes a comment suggesting to use `Vec::remove_item` when it stabilizes. Co-authored-by: Patrick LaFontaine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When copying multiple layers at the same time, we ignored
Testing
Tested on the skybox example with BC1 textures doing all layer copies.