[hal/vulkan] Wait for fence signalled in vkAcquireNextImage #8420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
ErichDonGubler
approved these changes
Oct 23, 2025
|
I'm not sure that I understand the note about the changelog, except in really specific case. Why does a backport mean we shouldn't include it in the mainline changelog? Are you only planning on omitting changelog entries when we're backporting to the most recent release branch? |
|
I will have changelog entries for the v26 backport, and the v27 backport, but for v28 from a user's perspective it will have been "already fixed in v27". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #8310
Backport to v27 #8419
Backport to v26 #8414
Description
This prevents frame pacing issues on vulkan/windows. See upstream issue for more information.
Testing
Manually tested
Squash or Rebase?
Izzacommit.
Checklist
Changelogs will be handled in backports.