-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove fragile dependency constraint on ordered-float.
#8371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bounds like `<=5.0` should never be used unless necessary to avoid bugs, because it will cause a build failure if another package has a requirement like `~5.1.0` or `>=5.1.0`. Upper bounds should always cut at a major version boundary, not before it.
|
I'm greatly surprised by Cargo's behavior here. Does using |
It seems like |
|
I filed rust-lang/cargo#16128 to ask for clarification about what |
|
I think that Anyway, I think that this would be nice to backport to v27. |
Bounds like `<=5.0` should never be used unless necessary to avoid bugs, because it will cause a build failure if another package has a requirement like `~5.1.0` or `>=5.1.0`. Upper bounds should always cut at a major version boundary, not before it.
Bounds like `<=5.0` should never be used unless necessary to avoid bugs, because it will cause a build failure if another package has a requirement like `~5.1.0` or `>=5.1.0`. Upper bounds should always cut at a major version boundary, not before it.
Bounds like `<=5.0` should never be used unless necessary to avoid bugs, because it will cause a build failure if another package has a requirement like `~5.1.0` or `>=5.1.0`. Upper bounds should always cut at a major version boundary, not before it.
|
Came here through the back-link of #6876, reminiscent of a previous PR by @kpreid at Traverse-Research/gpu-allocator#253 where we identified that the |
Connections
The problematic line was introduced by #6847 and last altered by #7618.
Description
Bounds like
<=5.0should never be used unless necessary to avoid bugs, because it will cause a build failure if another package has a requirement like~5.1.0or>=5.1.0. Upper bounds should always cut at a major version boundary, not before it.This PR replaces the
<=5.0bound with a well-behaved<6.0.Testing
xtask testSquash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.