-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: Update vulkan sdk to 1.4.321.0 #8157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I needed this while working on a (soon to be created) PR on my fork as I wanted an updated vulkan validation layers as it contains a rewrite of the range overlap checks, thought it was better in it's own change |
36675a8 to
5d0cc99
Compare
|
(Edited the description to show that this fixes #7943!) |
cwfitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one, then g2g
wgpu/.github/workflows/shaders.yml
Line 20 in 9a8dbfb
| VULKAN_SDK_VERSION: "1.4.313" |
5d0cc99 to
97d08ce
Compare
Oops 😅, fixed ! |
b6d3830 to
3e1cefc
Compare
| set -e | ||
| sudo apt-get update -y -qq | ||
| curl -L --retry 5 https://sdk.lunarg.com/sdk/download/${{ env.VULKAN_FULL_SDK_VERSION }}/linux/vulkansdk-linux-x86_64-${{ env.VULKAN_FULL_SDK_VERSION }}.tar.xz -o vulkan-sdk.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably do a follow up PR after this one to move this to a shared action like the mesa one, unless you think we should keep it as is, let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great!
Lunar discontinued providing ubuntu packages for the sdk and only provide linux tarballs now.
3e1cefc to
a94447a
Compare
Description
Lunar discontinued providing ubuntu packages for the sdk and only provide linux tarballs now.
Closes #7943
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.