Skip to content

Conversation

@Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Jul 31, 2025

Connections
Fixes #8008

Description
Prevents buffers and bind group layouts from being created with usages that can only be used with acceleration structures.

Testing
Adds a test.

Squash or Rebase?
squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec requested a review from a team as a code owner July 31, 2025 05:47
@Vecvec Vecvec force-pushed the resource-usages-rt branch 2 times, most recently from c0bf4dd to 120c181 Compare August 1, 2025 05:30
Copy link
Contributor

@andyleiserson andyleiserson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly.

I also confirmed that this resolves the relevant failing cases I had from fuzzing.

@Vecvec Vecvec force-pushed the resource-usages-rt branch from 8825d30 to 6e3e51d Compare August 3, 2025 06:56
@Vecvec Vecvec requested a review from andyleiserson August 3, 2025 08:13
Vecvec and others added 2 commits August 4, 2025 07:04
Fix spelling mistake.

Co-authored-by: Andy Leiserson <[email protected]>
@Vecvec Vecvec force-pushed the resource-usages-rt branch from 6e3e51d to f4a0c0d Compare August 3, 2025 19:05
@andyleiserson andyleiserson merged commit a116861 into gfx-rs:trunk Aug 4, 2025
38 checks passed
@Vecvec Vecvec deleted the resource-usages-rt branch August 4, 2025 18:52
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
…re not enabled (gfx-rs#8036)

* Prevent resources for acceleration structures being created if acceleration structures aren't supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating acceleration structure resources should require enabling a feature

2 participants