Skip to content

Conversation

@MichalMilewiczYoti
Copy link

SDK-1901 adding WATCHLIST_SCREENING check

Copy link
Collaborator

@ShamariYoti ShamariYoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, If you could add a : after the ticket in the commit and PR title so we can link the commints and PR to JIRA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@ShamariYoti ShamariYoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just probably want to address Ed's comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Michal 👌

@MichalMilewiczYoti MichalMilewiczYoti changed the title SDK-1901 adding WATCHLIST_SCREENING check SDK-1901: Adding WATCHLIST_SCREENING check Jan 3, 2022
@MichalMilewiczYoti MichalMilewiczYoti merged commit 20c7c02 into development Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants