Skip to content

ref(flags): Use SDK util functions for tracking feature flags [POC] #81159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ref(flags): Use SDK util functions for tracking feature flags [POC] #81159

wants to merge 1 commit into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 21, 2024 •
edited
Loading

This uses the util functions from the SDK beta to track feature flags in our SaaS. I do not think these will be what we ship with, but this shows what APIs are needed.

@billyvg
ref(flags): Use SDK util functions for tracking feature flags
3ea1789 
This uses the util functions from the SDK beta to track feature flags in our SaaS. I do not think these will be what we ship with, but this shows what APIs are needed.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2024
@billyvg billyvg changed the base branch from master to feat-sdk-upgrade-to-8.41.0-beta.0 November 21, 2024 22:05
@billyvg billyvg changed the title feat(sdk): Upgrade @sentry SDKs to v8.41.0-beta.0 ref(flags): Use SDK util functions for tracking feature flags Nov 21, 2024
@billyvg billyvg marked this pull request as ready for review November 21, 2024 22:06
@billyvg
Copy link
Member Author

billyvg commented Nov 21, 2024

@cmanallen @aliu39 Thinking more and more that we should move what we can into core and out of the integrations.

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
8245 8 8237 0
View the top 3 failed tests by shortest run time 
FeatureObserver observeOrganizationFlags should not change the functionality of `includes`
Stack Traces | 0.003s run time 
TypeError: inst.getFeatureFlags is not a function
    at Object.<anonymous> (.../app/utils/featureObserver.spec.ts:161:19)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
FeatureObserver observeProjectFlags and observeOrganizationFlags should add recently evaluated org and proj flags to the flag queue
Stack Traces | 0.003s run time 
TypeError: inst.getFeatureFlags is not a function
    at Object.<anonymous> (.../app/utils/featureObserver.spec.ts:244:19)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
FeatureObserver observeProjectFlags should add recently evaluated proj flags to the flag queue
Stack Traces | 0.003s run time 
TypeError: inst.getFeatureFlags is not a function
    at Object.<anonymous> (.../app/utils/featureObserver.spec.ts:184:19)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@billyvg
Copy link
Member Author

billyvg commented Nov 21, 2024

Oops need to update tests

@billyvg billyvg changed the title ref(flags): Use SDK util functions for tracking feature flags ref(flags): Use SDK util functions for tracking feature flags [POC] Nov 22, 2024
@billyvg
Copy link
Member Author

billyvg commented Nov 22, 2024

Gonna close this out actually, and just leave it as a PoC

@billyvg billyvg closed this Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@michellewzhang michellewzhang Awaiting requested review from michellewzhang

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@billyvg