feat: hashed user auth tokens #67969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mdtro
force-pushed
the
mdtro/apitoken-middleware-hash
branch
from
9ec71bc to
45aecd6
Compare
mdtro
force-pushed
the
mdtro/apitoken-middleware-hash
branch
from
22a57ad to
7fb9623
Compare
wedamija
approved these changes
Apr 1, 2024
- add tests for the hashing logic pre and post request - refactored helper function to return related user and application - call the helper function when authentication is happening under control silo mode
mdtro
force-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4f73517 to
c052cb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserAuthTokenAuthenticationmiddleware to support hashed token values. As tokens are used, it will store the appropriate hash value.apitoken.use-and-update-hash-ratethat will apply the code paths using the hashed values for lookups and updating the hashed values on plaintext tokens randomly based on the configured rate.apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.This previously resulted in INC-684 via PR #65941. The
hashed_tokenandhashed_refresh_tokencolumns now have indexes.