ref(integration): Break apart commonality #66623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66623 +/- ##
==========================================
- Coverage 84.32% 84.32% -0.01%
==========================================
Files 5314 5314
Lines 237620 237628 +8
Branches 41113 41115 +2
==========================================
+ Hits 200380 200386 +6
- Misses 37021 37023 +2
Partials 219 219
|
cathteng
reviewed
Mar 9, 2024
| if incident_exists_without_trigger or trigger_exists_without_incident: | ||
| # We can create a NotificationMessage if it has both, or neither, of incident and trigger. | ||
| # The following is an XNOR check for incident and trigger | ||
| if (self.incident_id is not None) != (self.trigger_action_id is not None): |
cathteng
approved these changes
Mar 11, 2024
ykamo001
added a commit
that referenced
this pull request
Mar 12, 2024
For Issue Alert notification messages, we need to be able to retrieve the parent message such that we can create a thread. Added logic to help achieve that query and flow, along with some tests. Requires: #66623
ykamo001
added a commit
that referenced
this pull request
Mar 12, 2024
Add repository into Issue Alert code path to start being able to use it, and create the FF that we will use to enable the logic. Requires: #66623
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break apart common code that will be leveraged for new work. There is some common logic between metric and issue alerts, so consolidating and testing that code will make it easier to work with for future iterations.