fix: Overwrite Android SDK during build #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
force-pushed
the
fix/android-sdk-copy
branch
from
afd8f94 to
8067c81
Compare
bitsandfoxes
force-pushed
the
fix/android-sdk-copy
branch
from
412d8a3 to
278b968
Compare
vaind
approved these changes
Feb 24, 2025
| File.Copy(file, destinationFile); | ||
| } | ||
| var fileName = Path.GetFileName(file); | ||
| _logger.LogDebug("Copying '{0}'", fileName); |
There was a problem hiding this comment.
To where? Above we log something with gradlePath but below we do targetPath
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Overwrite Android SDK during build ([#2031](https://github.com/getsentry/sentry-unity/pull/2031))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847
These changes make sure that the SDK now overwrites the Android SDK in the generated gradle project - if already present.