Skip to content

fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2025
Merged

fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests #5234

merged 3 commits into from
Oct 3, 2025

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Oct 2, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Temporarily hardcodes Metro 0.83.2 for E2E tests.
This change only affects E2E tests and can be a reference if a similar report comes up.

Opened an issue to revisit this workaround #5237

💡 Motivation and Context

The following error (example CI failure) seems to be introduced with Metro 0.83.3

TypeError: configs.toReversed is not a function                                                                                                                                                                                                 at mergeConfig (/home/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.81.0/RnDiffApp/node_modules/metro-config/src/loadConfig.js:179:35)

The failure seems not to be related to our code but to the fact that older node versions do not support this method.
Probably there would be a fix for this in Metro soon🤞otherwise we will need to investigate a proper fix (like polyfilling🤔).

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 389.37 ms 415.94 ms 26.57 ms
Size 17.75 MiB 19.69 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
23080e5 384.85 ms 382.57 ms -2.28 ms
1853710 555.47 ms 556.59 ms 1.12 ms
77061ed+dirty 369.55 ms 408.35 ms 38.80 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
f70acbf+dirty 373.39 ms 382.81 ms 9.43 ms
6479fd5+dirty 412.95 ms 434.02 ms 21.07 ms
8ece263 441.96 ms 444.96 ms 3.00 ms
af9331b 449.77 ms 479.20 ms 29.43 ms
a0b15d6 423.06 ms 437.77 ms 14.71 ms
46da307 455.92 ms 443.79 ms -12.13 ms

App size

Revision Plain With Sentry Diff
23080e5 17.75 MiB 19.68 MiB 1.94 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB
77061ed+dirty 17.75 MiB 19.68 MiB 1.94 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
f70acbf+dirty 17.75 MiB 19.68 MiB 1.94 MiB
6479fd5+dirty 17.75 MiB 19.68 MiB 1.94 MiB
8ece263 17.75 MiB 19.68 MiB 1.94 MiB
af9331b 17.75 MiB 19.68 MiB 1.94 MiB
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
46da307 17.75 MiB 19.68 MiB 1.93 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.81 ms 455.66 ms 62.85 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
77061ed+dirty 359.40 ms 424.10 ms 64.70 ms
95aaf8a+dirty 342.82 ms 393.75 ms 50.93 ms
f70acbf+dirty 520.12 ms 558.91 ms 38.79 ms
6479fd5+dirty 393.06 ms 434.04 ms 40.98 ms
c7f264b+dirty 356.98 ms 407.46 ms 50.48 ms
d916aa3+dirty 411.72 ms 451.76 ms 40.03 ms
20daa0a+dirty 352.33 ms 424.30 ms 71.98 ms
e2fa43d+dirty 326.56 ms 372.88 ms 46.32 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
46bd012+dirty 333.76 ms 359.24 ms 25.48 ms

App size

Revision Plain With Sentry Diff
77061ed+dirty 7.15 MiB 8.41 MiB 1.26 MiB
95aaf8a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f70acbf+dirty 7.15 MiB 8.41 MiB 1.26 MiB
6479fd5+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c7f264b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
d916aa3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
20daa0a+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e2fa43d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
46bd012+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.18 ms 1220.26 ms -6.92 ms
Size 2.63 MiB 3.98 MiB 1.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc9680d+dirty 1221.41 ms 1241.47 ms 20.06 ms
c9e95bd+dirty 1240.19 ms 1246.33 ms 6.14 ms
c1573b3+dirty 1203.33 ms 1202.47 ms -0.86 ms
49ef936+dirty 1228.42 ms 1217.09 ms -11.33 ms
8d89cc9+dirty 1222.92 ms 1239.43 ms 16.51 ms
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
9f211e3+dirty 1218.80 ms 1233.88 ms 15.08 ms
7be1f99+dirty 1226.69 ms 1217.76 ms -8.93 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
5c16cdc+dirty 1209.32 ms 1210.67 ms 1.35 ms

App size

Revision Plain With Sentry Diff
bc9680d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
c9e95bd+dirty 2.63 MiB 3.87 MiB 1.24 MiB
c1573b3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
49ef936+dirty 2.63 MiB 3.98 MiB 1.34 MiB
8d89cc9+dirty 2.63 MiB 3.96 MiB 1.33 MiB
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
9f211e3+dirty 2.63 MiB 3.91 MiB 1.28 MiB
7be1f99+dirty 2.63 MiB 3.81 MiB 1.18 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
5c16cdc+dirty 2.63 MiB 3.96 MiB 1.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.92 ms 1239.76 ms 2.84 ms
Size 3.19 MiB 4.54 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc9680d+dirty 1228.57 ms 1233.64 ms 5.07 ms
c9e95bd+dirty 1205.83 ms 1207.38 ms 1.55 ms
c1573b3+dirty 1245.69 ms 1245.48 ms -0.21 ms
49ef936+dirty 1221.27 ms 1221.60 ms 0.34 ms
8d89cc9+dirty 1232.35 ms 1228.53 ms -3.82 ms
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms
9f211e3+dirty 1215.38 ms 1218.15 ms 2.77 ms
7be1f99+dirty 1222.43 ms 1217.15 ms -5.28 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
5c16cdc+dirty 1235.67 ms 1241.18 ms 5.51 ms

App size

Revision Plain With Sentry Diff
bc9680d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
c9e95bd+dirty 3.19 MiB 4.44 MiB 1.25 MiB
c1573b3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
49ef936+dirty 3.19 MiB 4.54 MiB 1.36 MiB
8d89cc9+dirty 3.19 MiB 4.53 MiB 1.35 MiB
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
9f211e3+dirty 3.19 MiB 4.48 MiB 1.29 MiB
7be1f99+dirty 3.19 MiB 4.38 MiB 1.19 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
5c16cdc+dirty 3.19 MiB 4.53 MiB 1.34 MiB

@antonis antonis changed the title fix(e2e): Temporarily hardcode Metro 0.83.2 for E2E tests fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests Oct 3, 2025
@antonis antonis marked this pull request as ready for review October 3, 2025 09:35
@antonis antonis mentioned this pull request Oct 3, 2025
Closed
@alwx
Copy link
Contributor

alwx commented Oct 3, 2025

We probably need to create a follow-up issue or add a note to remove it later.

@antonis
Copy link
Contributor Author

antonis commented Oct 3, 2025

We probably need to create a follow-up issue or add a note to remove it later.

Yep, I've opened an issue to revisit this #5237

@antonis antonis merged commit bfe454a into main Oct 3, 2025
143 of 148 checks passed
@antonis antonis deleted the antonis/e2e-hardcode-metro branch October 3, 2025 11:24
antonis added a commit that referenced this pull request Oct 14, 2025
@antonis
Revert "fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests (#5234)"
be66759 
This reverts commit bfe454a.
@antonis antonis mentioned this pull request Oct 15, 2025
Merged
10 tasks
antonis added a commit that referenced this pull request Oct 15, 2025
@antonis
fix(metro): Unpin Metro 0.83.2 from E2E tests (#5269)
90edad7 
* Revert "fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests (#5234)"

This reverts commit bfe454a.

* Bump node to 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx alwx approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonis @alwx