Skip to content

Conversation

@idangozlan
Copy link
Contributor

@idangozlan idangozlan commented Sep 25, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

2 months ago there was a commit for making dot env file optional which broke the dot env file loading. This fixes it.

💚 How did you test it?

Locally

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Merge to v7/v6 and release.

@idangozlan idangozlan marked this pull request as ready for review September 25, 2025 18:48
@idangozlan idangozlan changed the title Fixed broken envs load fix(expo): broken envs load Sep 25, 2025
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM!
Thank you for your contribution @idangozlan 🙇

Leaving the final approval to @lucas-zimerman who may have more context from #5029

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this! LGTM!

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) September 29, 2025 17:26
@lucas-zimerman lucas-zimerman merged commit ec14be7 into getsentry:main Sep 29, 2025
51 checks passed
antonis added a commit that referenced this pull request Sep 30, 2025
Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: LucasZF <[email protected]>
@antonis antonis mentioned this pull request Sep 30, 2025
10 tasks
@antonis
Copy link
Contributor

antonis commented Oct 1, 2025

Thanks again for your contribution @idangozlan 🙇
Heads up that this has been released in 6.22.0 and will also be part of the next 7.x

@antonis
Copy link
Contributor

antonis commented Oct 9, 2025

The fix is now shipped with sentry-react-native 7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants