-
-
Notifications
You must be signed in to change notification settings - Fork 354
fix(metro): vendor countLines from metro #5185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metro): vendor countLines from metro #5185
Conversation
|
Thank you for your contribution! |
|
When should it merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
Thank you for this contribution @krystofwoldrich 🙇
Very active |
📢 Type of change
📜 Description
fixes: #5180
Metro
0.83.2changes exports fromcjs:module.exportstomjs:export(default).The named exports should not cause any issue, but
modules.exportstoexport defaultrequires reading.default.💡 Motivation and Context
Since there were multiple changes in recent Metro version I believe vendoring simple modules like
countLinewill be more stable in the future.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps