Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Sep 20, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fixes: #5180

Metro 0.83.2 changes exports from cjs:module.exports to mjs:export(default).

The named exports should not cause any issue, but modules.exports to export default requires reading .default.

💡 Motivation and Context

Since there were multiple changes in recent Metro version I believe vendoring simple modules like countLine will be more stable in the future.

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@lucas-zimerman
Copy link
Collaborator

Thank you for your contribution!

@MoeMamdouh
Copy link

When should it merge?

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸
Thank you for this contribution @krystofwoldrich 🙇

@antonis antonis merged commit 41ca4b4 into getsentry:main Sep 22, 2025
150 of 159 checks passed
@antonis antonis mentioned this pull request Sep 30, 2025
10 tasks
@saidmahamed9605-hue
Copy link

saidmahamed9605-hue commented Oct 3, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fixes: #5180

Metro 0.83.2 changes exports from cjs:module.exports to mjs:export(default).

The named exports should not cause any issue, but modules.exports to export default requires reading .default.

💡 Motivation and Context

Since there were multiple changes in recent Metro version I believe vendoring simple modules like countLine will be more stable in the future.

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Very active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: countLines is not a function

6 participants