Fix(V9) Fix check type test #4587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 412.45 ms | 431.62 ms | 19.18 ms |
| e54b1ed | 434.79 ms | 429.52 ms | -5.27 ms |
| 345e497 | 397.98 ms | 423.40 ms | 25.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| e54b1ed | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 345e497 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 375.33 ms | 377.23 ms | 1.90 ms |
| 71f7309+dirty | 361.15 ms | 369.90 ms | 8.75 ms |
| e54b1ed+dirty | 435.06 ms | 429.19 ms | -5.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 71f7309+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| e54b1ed+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 1227.33 ms | 1254.46 ms | 27.14 ms |
| 345e497+dirty | 1218.83 ms | 1218.73 ms | -0.10 ms |
| 71f7309+dirty | 1222.02 ms | 1224.81 ms | 2.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 345e497+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 71f7309+dirty | 2.63 MiB | 3.73 MiB | 1.10 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 1227.90 ms | 1230.92 ms | 3.02 ms |
| 345e497+dirty | 1210.67 ms | 1207.50 ms | -3.17 ms |
| 71f7309+dirty | 1206.00 ms | 1214.28 ms | 8.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 345e497+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 71f7309+dirty | 3.19 MiB | 4.30 MiB | 1.11 MiB |
10 tasks
krystofwoldrich
approved these changes
Feb 25, 2025
lucas-zimerman
added a commit
that referenced
this pull request
Apr 15, 2025
* bump SDKs * bump SDKs * fix build * fix tests * fix tests * fix lint errors * test ts 5.0 * rollback * fix merge conflict with yarn * fix new lint issue * sync yarn.lock with V7 branch and install new packages * ensure we are using the JS version from the default node resolution * update changelog with javascript version bump * fix check type (#4587) * add major changes to the SDK * fix lint * review check: fix changelog PR number / Fix wrapper incorrect null check / removed comment from rnerror handler / removed comment from span / fix test from userInteraction * fix incorrect cli version * fix lint * remove shutdowntimeout from android / use newer wizard version * rollback feedback test change, rollback jest version, fix safe test * return shutdowntimeout * explain tracing sample rate * fix tracing extension test * lint fix * update changelog * fix yarn lock merge/ fix ts-jest version no longer exists / fix core version on samples and e2e * fix lint on addTimeToInitialDisplay * fix issue with UIManager test * moved major changes to the correct spot
lucas-zimerman
added a commit
that referenced
this pull request
Apr 15, 2025
* bump SDKs * bump SDKs * fix build * fix tests * fix tests * fix lint errors * test ts 5.0 * rollback * fix merge conflict with yarn * fix new lint issue * sync yarn.lock with V7 branch and install new packages * ensure we are using the JS version from the default node resolution * update changelog with javascript version bump * fix check type (#4587) * add major changes to the SDK * fix lint * review check: fix changelog PR number / Fix wrapper incorrect null check / removed comment from rnerror handler / removed comment from span / fix test from userInteraction * fix incorrect cli version * fix lint * remove shutdowntimeout from android / use newer wizard version * rollback feedback test change, rollback jest version, fix safe test * return shutdowntimeout * explain tracing sample rate * fix tracing extension test * lint fix * update changelog * fix yarn lock merge/ fix ts-jest version no longer exists / fix core version on samples and e2e * fix lint on addTimeToInitialDisplay * fix issue with UIManager test * add browserSessionIntegration for web * moved major changes to the correct spot * merge father branch, update changelog about react native web changes * add PR number * Update CHANGELOG.md Co-authored-by: Antonis Lilis <[email protected]> * Update CHANGELOG.md Co-authored-by: Antonis Lilis <[email protected]> --------- Co-authored-by: Antonis Lilis <[email protected]>
lucas-zimerman
added a commit
that referenced
this pull request
Apr 15, 2025
* bump SDKs * bump SDKs * fix build * fix tests * fix tests * fix lint errors * test ts 5.0 * rollback * fix merge conflict with yarn * fix new lint issue * sync yarn.lock with V7 branch and install new packages * ensure we are using the JS version from the default node resolution * update changelog with javascript version bump * fix check type (#4587) * add major changes to the SDK * fix lint * review check: fix changelog PR number / Fix wrapper incorrect null check / removed comment from rnerror handler / removed comment from span / fix test from userInteraction * fix incorrect cli version * fix lint * remove shutdowntimeout from android / use newer wizard version * rollback feedback test change, rollback jest version, fix safe test * return shutdowntimeout * explain tracing sample rate * fix tracing extension test * lint fix * update changelog * fix yarn lock merge/ fix ts-jest version no longer exists / fix core version on samples and e2e * fix lint on addTimeToInitialDisplay * fix issue with UIManager test * use main carrier * fix yarn lint * moved major changes to the correct spot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
With V9, a new issue was found here getsentry/sentry-javascript#15471.
To mitigate it, I have declared new globals for V9.
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog