Skip to content

fix(modules-collector): Fix info output log to show from where modules are collected #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix(modules-collector): Fix info output log to show from where modules are collected #3316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efdefb8
fix(modules-collector): Fix info output log to show from where the mo…
krystofwoldrich Oct 2, 2023
c183b7b
Use join
krystofwoldrich Oct 2, 2023
17f9ebc
Update CHANGELOG.md
krystofwoldrich Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Change log output to show what paths are considered when collecting modules ([#3316](https://github.com/getsentry/sentry-react-native/pull/3316))

## 5.10.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion src/js/tools/ModulesCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default class ModulesCollector {

logger.info('Reading source map from', sourceMapPath);
logger.info('Saving modules to', outputModulesPath);
logger.info('Resolving modules from paths', outputModulesPath);
logger.info('Resolving modules from paths', modulesPaths.join(', '));

if (!existsSync(sourceMapPath)) {
logger.error(`Source map file does not exist at ${sourceMapPath}`);
Expand Down