Skip to content

Conversation

@pvegh
Copy link
Contributor

@pvegh pvegh commented Sep 21, 2023

by enabling buildConfig since it's using custom buildConfig field
So that consumer projects don't have to globally enable this themselves leading to performance impact

📢 Type of change

  • Bugfix
  • New feature
  • [ x ] Enhancement
  • Refactoring

📜 Description

Since AGP8 this flag is disabled by default. Consumer projects have to enable this flag in them globally if the library doesn't do this correctly itself, but uses custom buildConfig fields.

💡 Motivation and Context

No errors and better build performance than the workaround in consuming projects would be.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

by enabling buildConfig since it's using custom buildConfig field
@krystofwoldrich
Copy link
Contributor

Thank you for the enhancement. Let's check if CI passes.

@pvegh
Copy link
Contributor Author

pvegh commented Sep 27, 2023

I'm not sure my changes would cause the failed checks @krystofwoldrich

@pvegh
Copy link
Contributor Author

pvegh commented Sep 29, 2023

One of your paying customers is eagerly waiting for this, I even created the patch to make things faster.
We'd like to see a quick release with this. Thanks!

@krystofwoldrich
Copy link
Contributor

Thanks, the CI failed on a missing token needed for the tests, I've triggered it from my branch, should be fine now.

Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing the SDK for AGP 8. 🚀

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) October 4, 2023 12:36
@krystofwoldrich krystofwoldrich merged commit 691f2db into getsentry:main Oct 4, 2023
@pvegh pvegh deleted the patch-1 branch October 4, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants