fix(aws): Inject scopes in TimeoutThread exception with AWS lambda #4914
+91
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event, hint = event_from_exception( | ||
| exc_info, | ||
| client_options=client.options, | ||
| mechanism={"type": "threading", "handled": False}, |
There was a problem hiding this comment.
Can the mechanism be changed?
Keeping type=threading would keep it consistent with previous behaviour.
Changing this could help us distinguish AWS lambda timeout exceptions with exceptions caught by the threading integration that are unrelated to AWS lambda timeouts.
There was a problem hiding this comment.
It's technically incorrect but I'd keep it to not change existing behavior
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sentrivana
approved these changes
Oct 17, 2025
| event, hint = event_from_exception( | ||
| exc_info, | ||
| client_options=client.options, | ||
| mechanism={"type": "threading", "handled": False}, |
There was a problem hiding this comment.
It's technically incorrect but I'd keep it to not change existing behavior
|
We also use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing tags and breadcrumbs on
sentry_sdk>=2.26.1when lambda functions time out are an unintended consequences of 2d392afYou can verify the change with the new unit test.
To test manually:
sam-app/hello_world/app.py.sam-app/hello_world/requirements.txtwithFollow the commands to run the lambda in the
README.mdof the project. That is, in separate terminals runIssues
More information about how I found the bug are described in #4912.
Closes #4894
Reminders
tox -e linters.feat:,fix:,ref:,meta:)