-
Notifications
You must be signed in to change notification settings - Fork 562
fix(aws): Inject scopes in TimeoutThread exception with AWS lambda #4914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(aws): Inject scopes in TimeoutThread exception with AWS lambda #4914
Conversation
event, hint = event_from_exception( | ||
exc_info, | ||
client_options=client.options, | ||
mechanism={"type": "threading", "handled": False}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the mechanism be changed?
Keeping type=threading
would keep it consistent with previous behaviour.
Changing this could help us distinguish AWS lambda timeout exceptions with exceptions caught by the threading integration that are unrelated to AWS lambda timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically incorrect but I'd keep it to not change existing behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice!
event, hint = event_from_exception( | ||
exc_info, | ||
client_options=client.options, | ||
mechanism={"type": "threading", "handled": False}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically incorrect but I'd keep it to not change existing behavior
We also use |
Description
Missing tags and breadcrumbs on
sentry_sdk>=2.26.1
when lambda functions time out are an unintended consequences of 2d392afYou can verify the change with the new unit test.
To test manually:
sam-app/hello_world/app.py
.sam-app/hello_world/requirements.txt
withFollow the commands to run the lambda in the
README.md
of the project. That is, in separate terminals runIssues
More information about how I found the bug are described in #4912.
Closes #4894
Reminders
tox -e linters
.feat:
,fix:
,ref:
,meta:
)