Skip to content

ref(tracing): Use float for sample rand #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 6, 2025

Closes #4270

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.12%. Comparing base (1804955) to head (7c10d00).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/utils.py 20.00% 3 Missing and 1 partial ⚠️
sentry_sdk/tracing_utils.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
+ Coverage   85.07%   85.12%   +0.04%     
==========================================
  Files         156      156              
  Lines       15984    15988       +4     
  Branches     2718     2718              
==========================================
+ Hits        13598    13609      +11     
+ Misses       1600     1593       -7     
  Partials      786      786              
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 86.61% <100.00%> (-0.03%) ⬇️
sentry_sdk/tracing_utils.py 88.21% <80.00%> (-0.39%) ⬇️
sentry_sdk/utils.py 88.11% <20.00%> (-0.41%) ⬇️

... and 3 files with indirect coverage changes

@sentrivana sentrivana changed the title Remove Decimal Use float for sample rand Aug 6, 2025
@sentrivana sentrivana marked this pull request as ready for review August 7, 2025 11:14
@sentrivana sentrivana requested a review from a team as a code owner August 7, 2025 11:14
@sentrivana sentrivana changed the base branch from ivana/random-perf-improvements to master August 7, 2025 14:30
@sentrivana sentrivana marked this pull request as draft August 12, 2025 11:31
cursor[bot]

This comment was marked as outdated.

@sentrivana sentrivana marked this pull request as ready for review August 14, 2025 12:34
@sentrivana sentrivana changed the title Use float for sample rand ref(tracing): Use float for sample rand Aug 14, 2025
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from Decimal
1 participant