Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 14, 2025

This reverts commit e05ed0a.

same_process_as_parent is True by default, so we actually don't have a way of detecting whether this was set explicitly by the user or not.

Removing the deprecation altogether -- no one's using this.

Closes #4289

@sentrivana sentrivana requested a review from a team as a code owner April 14, 2025 14:40
@sentrivana sentrivana linked an issue Apr 14, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (296e288) to head (4ecd5a1).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4290      +/-   ##
==========================================
- Coverage   79.54%   79.50%   -0.05%     
==========================================
  Files         142      142              
  Lines       15907    15905       -2     
  Branches     2722     2721       -1     
==========================================
- Hits        12654    12645       -9     
- Misses       2389     2394       +5     
- Partials      864      866       +2     
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 77.73% <ø> (+0.11%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sentrivana sentrivana enabled auto-merge (squash) April 15, 2025 10:09
@sentrivana sentrivana merged commit 706d2d2 into master Apr 15, 2025
137 checks passed
@sentrivana sentrivana deleted the ivana/undeprecate-same-process-as-parent branch April 15, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeprecationWarning raised when using sentry_sdk.trace

3 participants