Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 10, 2025 11:35
@codecov
Copy link

codecov bot commented Apr 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20459 1 20458 4415
View the top 1 failed test(s) by shortest run time
tests.test_basics test_classmethod_tracing
Stack Traces | 0.13s run time
tests/test_basics.py:811: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 3 == 1
E    +  where 3 = <MagicMock name='mock.start_child' id='139892869571984'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Currently, this property has type `Any`, but it can now be changed to `Optional[Span]`

Depends on:
  - #4263
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/simplify-root_span branch from 8761993 to b26e009 Compare April 10, 2025 12:28
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/root_span-type branch from cbce9ed to 6d441a1 Compare April 10, 2025 12:28
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner April 10, 2025 12:28
Base automatically changed from szokeasaurusrex/root_span-type to potel-base April 24, 2025 11:00
@antonpirker antonpirker merged commit d4b9d50 into potel-base Apr 24, 2025
@antonpirker antonpirker deleted the szokeasaurusrex/simplify-root_span branch April 24, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants