Fix ray tests in POTel #3877
Merged
Fix ray tests in POTel #3877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonpirker
requested review from
sentrivana and
sl0thentr0py
and removed request for
sl0thentr0py
❌ 257 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
approved these changes
Dec 17, 2024
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
lgtm, see one small comment
Comment on lines
+64
to
+67
| sentry_sdk.get_current_scope().set_transaction_name( | ||
| root_span_name, | ||
| source=TRANSACTION_SOURCE_TASK, | ||
| ) |
Contributor
There was a problem hiding this comment.
Does this work before we even started the transaction? Maybe logically it'd better fit inside the root_span context manager?
Contributor
Author
There was a problem hiding this comment.
Because this sets the transaction name only on the scope, this should be fine.
The other question this brought up inside me is why the ray integration does no isolation scope forking anywhere...
I will test this tomorrow.
Contributor
Author
There was a problem hiding this comment.
Ok, this works and is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to set the transaction name.