Skip to content

Fix httplib #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix httplib #3820

merged 1 commit into from
Nov 28, 2024

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Nov 22, 2024

No description provided.

sl0thentr0py
sl0thentr0py commented Nov 22, 2024
View reviewed changes
sentry_sdk/integrations/opentelemetry/utils.py
)
description = f"{http_method} {url}"
# TODO-neel-potel remove description completely
description = span_attributes.get(
Copy link
Member Author

@sl0thentr0py sl0thentr0py Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic is a mess, I will remove description completely later.
Also this function messes up order of precedence of op and name/desc if explicitly set.

sl0thentr0py
sl0thentr0py commented Nov 22, 2024
View reviewed changes
tests/integrations/stdlib/test_httplib.py
# HTTPSConnection.send is passed a string containing (among other things)
# the headers on the request. Mock it so we can check the headers, and also
# so it doesn't try to actually talk to the internet.
mock_send = mock.Mock()
Copy link
Member Author

@sl0thentr0py sl0thentr0py Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the mock in favor of the fixture above

sl0thentr0py
sl0thentr0py commented Nov 22, 2024
View reviewed changes
tests/integrations/stdlib/test_httplib.py
traces_sample_rate=1.0,
)

headers = {
Copy link
Member Author

@sl0thentr0py sl0thentr0py Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not necessary for this test at all

@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

❌ 1003 Tests Failed:

Tests completed Failed Passed Skipped
19684 1003 18681 4424
View the top 2 failed tests by shortest run time 
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.001s run time 
.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.002s run time 
.../integrations/opentelemetry/test_span_processor.py:287: in test_on_start_transaction
    with mock.patch(
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1463: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1436: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'
View the full list of 1 ❄️ flaky tests 
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction

Flake rate in main: 90.70% (Passed 4 times, Failed 39 times)

Stack Traces | 0.001s run time 
.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sl0thentr0py sl0thentr0py merged commit 7c2d770 into potel-base Nov 28, 2024
48 of 123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-httplib branch November 28, 2024 13:00
@sl0thentr0py sl0thentr0py mentioned this pull request Nov 28, 2024
Closed
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sl0thentr0py @sentrivana