Skip to content

Fix asyncio tests #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix asyncio tests #3811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/integrations/asyncio/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ async def test_create_task(

events = capture_events()

with sentry_sdk.start_transaction(name="test_transaction_for_create_task"):
with sentry_sdk.start_span(name="test_transaction_for_create_task"):
with sentry_sdk.start_span(op="root", name="not so important"):
tasks = [event_loop.create_task(foo()), event_loop.create_task(bar())]
await asyncio.wait(tasks, return_when=asyncio.FIRST_EXCEPTION)
Expand Down Expand Up @@ -117,7 +117,7 @@ async def test_gather(

events = capture_events()

with sentry_sdk.start_transaction(name="test_transaction_for_gather"):
with sentry_sdk.start_span(name="test_transaction_for_gather"):
with sentry_sdk.start_span(op="root", name="not so important"):
await asyncio.gather(foo(), bar(), return_exceptions=True)

Expand Down Expand Up @@ -160,7 +160,8 @@ async def test_exception(

events = capture_events()

with sentry_sdk.start_transaction(name="test_exception"):
with sentry_sdk.start_span(name="test_exception"):
sentry_sdk.get_isolation_scope().set_transaction_name("test_exception")
with sentry_sdk.start_span(op="root", name="not so important"):
tasks = [event_loop.create_task(boom()), event_loop.create_task(bar())]
await asyncio.wait(tasks, return_when=asyncio.FIRST_EXCEPTION)
Expand Down Expand Up @@ -375,7 +376,7 @@ async def test_span_origin(

events = capture_events()

with sentry_sdk.start_transaction(name="something"):
with sentry_sdk.start_span(name="something"):
tasks = [
event_loop.create_task(foo()),
]
Expand Down
Loading