- 
                Notifications
    
You must be signed in to change notification settings  - Fork 568
 
Fix asyncpg spans #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Fix asyncpg spans #3639
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          ❌ 2925 Tests Failed:
 View the top 3 failed tests by shortest run time
 
 
 To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard  | 
    
              
                    sentrivana
  
              
              commented
              
                  
                    Oct 11, 2024 
                  
              
              
            
            
      Comment on lines
    
      +82
     to 
      +83
    
  
  | with capture_internal_exceptions(): | ||
| add_query_source(span) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the query source change from the PR description
      
        
      
      
  
    54 tasks
  
              
                    sl0thentr0py
  
              
              approved these changes
              
                  
                    Oct 11, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Change
span.set_datatospan.set_attributeChange
start_transactions in the tests tostart_spansStringify
db.params,db.paramstyle,db.cursor❗ Change how adding query source works.
Previously, we first let the DB span finish and then looked at its start and end timestamps to figure out if the query was slow enough to attach query data.
With the switch to OTel, we can no longer put stuff on a finished span, meaning the slow query span still has to be alive when adding data to it. So instead of looking at the end timestamp of a finished span, we keep the span alive and instead look at current time at the point when the query is finished.
This means the DB span will be longer than the actual query (since it now includes adding query data).