Skip to content

Make sure op/name/description are set correctly on transactions/spans #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2024
Merged

Make sure op/name/description are set correctly on transactions/spans #3519

merged 6 commits into from
Sep 12, 2024
+68 −2

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Sep 11, 2024 •
edited
Loading

Make sure that op, name, description are set correctly on Spans and Transactions.

@codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

❌ 3169 Tests Failed:

Tests completed Failed Passed Skipped
16691 3169 13522 1445
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_transaction_events[<lambda>3-success]
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

sl0thentr0py
sl0thentr0py reviewed Sep 11, 2024
View reviewed changes
@antonpirker antonpirker marked this pull request as ready for review September 12, 2024 11:02
@antonpirker antonpirker merged commit 13441e3 into potel-base Sep 12, 2024
@antonpirker antonpirker deleted the antonpirker/python/potel/fix-op-extraction branch September 12, 2024 11:03
@antonpirker antonpirker mentioned this pull request Sep 12, 2024
Closed
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonpirker @sl0thentr0py @sentrivana