Set the correct SpanContext in continue_trace #3475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 3863 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sl0thentr0py
force-pushed
the
neel/potel/is-remote
branch
3 times, most recently
from
2f4e723 to
d037a10
Compare
sl0thentr0py
changed the title
sl0thentr0py
changed the title
Member
Author
|
working distributed trace tested with
|
sl0thentr0py
force-pushed
the
neel/potel/is-remote
branch
from
d037a10 to
a01604e
Compare
sentrivana
approved these changes
Aug 30, 2024
|
|
||
| def start_span(self, span=None, custom_sampling_context=None, **kwargs): | ||
| # type: (Optional[POTelSpan], Optional[SamplingContext], Any) -> POTelSpan | ||
| # TODO-neel-potel ideally want to remove the span argument, discuss with ivana |
Contributor
There was a problem hiding this comment.
If the only use for this was using the Transaction from continue_trace, let's get rid of the arg
sl0thentr0py
force-pushed
the
neel/potel/is-remote
branch
from
a01604e to
35e146c
Compare
sl0thentr0py
force-pushed
the
neel/potel/is-remote
branch
from
35e146c to
0082dd9
Compare
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes incoming distributed tracing work and finishes implementing
continue_tracestart_spantoPOTelScopefor now that is a simplified version of the original that just creates aPOTelSpancontinue_tracenow adds a fake remoteNonRecordingSpanwith the correcttrace_id,parent_span_idandparent_sampledfields taken from thePropagationContexttrace_idandspan_idproperties onPOTelSpancloses #3476