chore: remove workaround for sentry-dotnet issue #3141 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
chore/remove-on-exit-flush-workaround
branch
from
4b8222f to
9a1d9ba
Compare
Flash0ver
reviewed
Jul 15, 2025
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - Remove workaround for Dotnet SDK issue causing a hang on process exit - automatic flush should work now. ([#85](https://github.com/getsentry/sentry-powershell/pull/85)) | |||
There was a problem hiding this comment.
suggestion: Swap the two parts of the note so that the actual fix/improvement comes first.
e.g.
Suggested change
| - Remove workaround for Dotnet SDK issue causing a hang on process exit - automatic flush should work now. ([#85](https://github.com/getsentry/sentry-powershell/pull/85)) | |
| - Automatic flush by removing workaround for Dotnet SDK issue causing a hang on process exit. ([#85](https://github.com/getsentry/sentry-powershell/pull/85)) |
Flash0ver
approved these changes
Jul 15, 2025
Yes I'm aware, I didn't merge this because I'm not convinced about the changelog item being true and wanted to test it. I may just remove it though as it's not a big deal. I'll see if I can get to this soonish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fixed now by getsentry/sentry-dotnet#4323
We need to wait for a release to nuget in order to verify.