Skip to content

ref(logs): extract attribute compilation to dedicated method in LogsHandler #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 5, 2025
+11 −1
Merged

ref(logs): extract attribute compilation to dedicated method in LogsHandler #1931

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef8db97
ref(logs): extract attribute compilation to dedicated method in LogsH…
huangdijia Sep 30, 2025
a20fe76
ref(logs): use Arr utility to simplify attribute compilation in compi…
huangdijia Oct 16, 2025
afb5ba5
Replace array spread with array_merge in compileAttributes
huangdijia Oct 24, 2025
d5ee4b2
Update sentry.origin attribute value
huangdijia Oct 24, 2025
00eafe9
Simplify attribute compilation in LogsHandler
huangdijia Oct 28, 2025
f7afeef
ref(logs): remove unused Arr utility import and improve compileAttrib…
huangdijia Nov 1, 2025
26e921a
更新 LogsHandler.php
huangdijia Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Monolog/LogsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function handle($record): bool
self::getSentryLogLevelFromMonologLevel($record['level']),
$record['message'],
[],
array_merge($record['context'], $record['extra'], ['sentry.origin' => 'auto.log.monolog'])
$this->compileAttributes($record)
);

return $this->bubble === false;
Expand Down Expand Up @@ -123,4 +123,14 @@ public function __destruct()
// Just in case so that the destructor can never fail.
}
}

/**
* @param array<string,mixed>|LogRecord $record
*
* @return array<string,mixed>
*/
protected function compileAttributes($record): array
{
return array_merge($record['context'], $record['extra'], ['sentry.origin' => 'auto.log.monolog']);
}
}