Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Improve error handling of releases creation #29

@ehmicky

Description

@ehmicky

When releases are created and an error is thrown, there is currently some error handling code:

https://github.com/getsentry/sentry-netlify-build-plugin/blob/91d932960f4e1c1c8ba4648cb837000f590b06a0/index.js#L84-95

However, that code did not handle the following two errors which happened in production:

Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases new d6678d230f575c70ada04dcdada4ada2e9f7dd54
error: API request failed
  caused by: [7] Couldn't connect to server
Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases new 0c0e7d6430d4ac5cea7f0af6abbed6279d817547
error: API request failed
  caused by: [6] Couldn't resolve host name
Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases new 0.1.0
error: project not found
Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases new 
error: Invalid value for '<VERSION>': Invalid release version. Slashes and certain whitespace characters are not permitted.
Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases new 8c567894abb89c92dd6957d25369f55537fee4ed
error: request failed because API URL was incorrectly formatted
  caused by: bad sentry url: not on URL root (https://[email protected]/1199386)
Command failed: /opt/buildhome/.netlify-build-plugins/node_modules/@sentry/cli/sentry-cli releases deploys 1e3b19a91fa15d94fae858e0d8709bfee5c8b793 new -e deploy-preview
error: API request failed
  caused by: [35] SSL connect error

Are those errors due to a user issue or a problem with Sentry? In the first case, would it be possible to add some additional logic to report those as user errors? Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions