remove use-strict #981
Merged
remove use-strict #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm nervous about this change without rigorous cross-browser testing. |
|
I will verify this once we get all required browsers tested on SauceLabs |
kamilogorek
force-pushed
the
dont-use-strict
branch
from
00de39a to
6f5eed1
Compare
|
@benvinegar all green 👌 |
kamilogorek
requested review from
a team
and removed request for
benvinegar
mitsuhiko
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979 .
Verified locally but would be nice to test if we had a selenium / firefox environment