Skip to content

Implement console.assert wrapping for console plugin. #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Implement console.assert wrapping for console plugin. #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a0cc6f
Implement `console.assert` wrapping for console plugin.
frewsxcv Jul 15, 2016
8d33723
Address @benvinegar's suggestions.
frewsxcv Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
'use strict';

var wrapConsoleMethod = require('../src/console').wrapMethod;
var wrapConsoleAssert = require('../src/console').wrapAssert;

function consolePlugin(Raven, console, pluginOptions) {
console = console || window.console || {};
Expand All @@ -28,6 +29,10 @@ function consolePlugin(Raven, console, pluginOptions) {
wrapConsoleMethod(console, level, callback);
level = logLevels.pop();
}

if (console.assert) {
wrapConsoleAssert(console);
}
}

module.exports = consolePlugin;
20 changes: 19 additions & 1 deletion src/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,24 @@ var wrapMethod = function(console, level, callback) {
};
};

var wrapAssert = function(console) {
console.assert = function () {
var args = [].slice.call(arguments);
var result = args.shift();
if (!result) {
args.unshift('Assertion failed');
// IE9 doesn't allow calling apply on console functions directly
// See: https://stackoverflow.com/questions/5472938/does-ie9-support-console-log-and-is-it-a-real-function#answer-5473193
Function.prototype.apply.call(
console.error,
console,
args
);
}
};
};

module.exports = {
wrapMethod: wrapMethod
wrapMethod: wrapMethod,
wrapAssert: wrapAssert
};