Skip to content

Add TypeScript type definitions (from DefinitelyTyped) #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [Gitflow] Merge master into develop
merged 6 commits into from
Jun 19, 2016
Merged

Add TypeScript type definitions (from DefinitelyTyped) #610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc03a30
Add TypeScript type definitions (from DefinitelyTyped)
benvinegar Jun 17, 2016
5cca6b3
Test typescript typings
benvinegar Jun 18, 2016
fa413be
Ignore TypeScript compiler output
benvinegar Jun 18, 2016
2bbe46e
Add union types
benvinegar Jun 18, 2016
c6ce3dc
Fix mixed array types
benvinegar Jun 18, 2016
cf23cd6
No more js output files from tsc
benvinegar Jun 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion typescript/raven-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,37 @@ import Raven, {RavenOptions} from '..';

Raven.config('https://[email protected]/1').install();

// Test regex options
var options: RavenOptions = {
logger: 'my-logger',
ignoreUrls: [
/graph\.facebook\.com/i
],
ignoreErrors: [
'fb_xd_fragment'
/fb_xd_fragment/
],
includePaths: [
/https?:\/\/(www\.)?getsentry\.com/,
/https?:\/\/d3nslu0hdya83q\.cloudfront\.net/
],
whitelistUrls: [
/https?:\/\/google\.com/
]
};

// Test string params
options = {
ignoreUrls: [
'graph.facebook.com'
],
ignoreErrors: [
'fb_xd_fragment'
],
includePaths: [
'https://www.getsentry.com'
],
whitelistUrls: [
'https://www.google.com'
]
};

Expand Down
8 changes: 4 additions & 4 deletions typescript/raven.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ export interface RavenOptions {
serverName?: string;

/** List of messages to be fitlered out before being sent to Sentry. */
ignoreErrors?: string[];
ignoreErrors?: RegExp[] | string[];

/** Similar to ignoreErrors, but will ignore errors from whole urls patching a regex pattern. */
ignoreUrls?: RegExp[];
ignoreUrls?: RegExp[] | string[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't cover the case of:

ignoreUrls: [
  /foo/,
  'bar',
]

Does it?

Copy link
Contributor Author

@benvinegar benvinegar Jun 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh you're right, just tested it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. We're learning TypeScript!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏


/** The inverse of ignoreUrls. Only report errors from whole urls matching a regex pattern. */
whitelistUrls?: RegExp[];
whitelistUrls?: RegExp[] | string[];

/** An array of regex patterns to indicate which urls are a part of your app. */
includePaths?: RegExp[];
includePaths?: RegExp[] | string[];

/** Additional data to be tagged onto the error. */
tags?: {
Expand Down