Skip to content

Conversation

benvinegar
Copy link
Contributor

So ... including plugins/console.js into raven.js was a bad idea. It created a circular dependency where console.js => singleton.js => raven.js => console.js (and so on) ... causing the CDN build to error because of the way plugins are auto-initialized.

My solution is to create a new file src/console.js and utility method wrapMethod that is shared by both raven.js and plugins/console.js. No more circular dependency, no more tears, and the CDN version now builds fine.

There were already unit + integration tests for the console plugin and console breadcrumbs, and everything seems green.

Will cut 3.0.1 after this lands.

cc @mitsuhiko @mattrobenolt

@mitsuhiko
Copy link
Contributor

Nothing bad sticks out but I'm also not particularly familiar with how we include the plugins.

@benvinegar benvinegar merged commit 996e09a into master May 3, 2016
@benvinegar benvinegar deleted the fix-console-plugin branch May 3, 2016 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants