-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(react-router): Add createSentryHandleError
#17235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
captureException(error, { | ||
mechanism: { | ||
type: 'react-router', | ||
handled: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to double check: We don't actually know if users handle this error, correct? If so, then handled: false
is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically the last point an unhandled error can reach on the server, so this should be fine 👍
closes #17228
closes https://linear.app/getsentry/issue/JS-793/improve-sentry-react-router-steps
This one adds a
createSentryHandleError
utility function, that can be used like the existingcreateSentryHandleRequest
;Will need a docs update as well once released.