-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Add eventLoopBlockIntegration
#16709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1419bd9
to
b49f3f5
Compare
f337741
to
0745a20
Compare
AbhiPrasad
reviewed
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split this PR up
- Adding just the
@sentry/node-native
package with no implementation. Same approach as #16652 - the integration tests + main implementation (this PR)
AbhiPrasad
pushed a commit
that referenced
this pull request
Jun 24, 2025
- Ref #16709 (review) Adds an empty `@sentry/node-native` package
@sentry review |
AbhiPrasad
reviewed
Jun 24, 2025
Co-authored-by: Abhijeet Prasad <[email protected]>
…vascript into timfish/feat/new-anr
@sentry/node-native
with threadBlockedIntegration
eventLoopBlockIntegration
dev-packages/node-integration-tests/suites/thread-blocked-native/test.ts
Show resolved
Hide resolved
…vascript into timfish/feat/new-anr
AbhiPrasad
approved these changes
Jul 2, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
eventLoopBlockIntegration
which uses@sentry-internal/node-native-stacktrace
to detect and capture blocked event loopsnew Worker(new URL('./thread-blocked-watchdog.js', import.meta.url))
which will be bundled correctly by latest Vite and Webpack 5@sentry/node-native/thread-blocked-watchdog
which should output tothread-blocked-watchdog.js
next to your bundle.Usage
If you instrument your application via the Node.js
--import
flag, this instrumentation will be automatically applied to all worker threads.instrument.mjs
app.mjs
worker.mjs
Start your application:
Blocked events are captured with stack traces for all threads: