-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Use runAfterProductionCompile
to upload sourcemaps and do release management
#15779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…release management
size-limit report 📦
|
afterProductionBuild
to upload sourcemaps and do release managementrunAfterProductionCompile
to upload sourcemaps and do release management
This is still blocked until Next.js adds debug ID support. We could do name based sourcemap resolution but that takes us back to the dark ages 💀 |
Closing to get this PR out of my PR tab. Feel free to take the branch. With Love |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref vercel/next.js#77345
Next.js is adding an
runAfterProductionCompile
hook that we can use to upload sourcemaps and manage release.Unfortunately, because we need to support older Next.js versions, we still need to maintain our Webpack logic, so for now I opted to run the
runAfterProductionCompile
logic only if we never ran our webpack logic. That way we should never do duplicate work.