Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 16, 2024

I noticed that after #14729, now tests started failing 😬

The reason:

  • We run deno check ./build/index.mjs
  • This checks the types, but we now do not inline those anymore into the generated ./build/index.d.ts file
  • Instead, we just import them from @sentry/core
  • Now deno check downloads the latest version of core into a local tmp folder and uses this for checking
  • But there are different exports there than locally, leading to test failures 😬

this PR simple kills the type tests - not sure if we need them/they are needed, but I can't think of a different way to make this work, there isn't really a way (as far as I see?) to tell deno check to consider a dependency from a local path instead 😬

@mydea mydea self-assigned this Dec 16, 2024
@mydea mydea enabled auto-merge (squash) December 16, 2024 16:45
@mydea mydea merged commit edbb214 into develop Dec 16, 2024
33 checks passed
@mydea mydea deleted the fn/kill-deno-type-check branch December 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants