Skip to content

feat(utils): Backfill stack trace on fetch errors if it is missing #12389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2024
Merged

feat(utils): Backfill stack trace on fetch errors if it is missing #12389

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a294a0
feat(utils): Backfill stack trace on fetch errors if it is missing
Jun 6, 2024
c0e1ad6
Merge branch 'develop' into lforst-fix-failed-to-fetch
Jun 10, 2024
859d2b1
framesToPop
Jun 10, 2024
9518994
Odd test fix
Jun 10, 2024
79b6fd5
test
Jun 10, 2024
6ec2efe
more narrow test
Jun 11, 2024
3cc270d
lint
Jun 11, 2024
dac3391
fix trace locality
Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/utils/src/instrument/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
import type { HandlerDataFetch } from '@sentry/types';

import { isError } from '../is';
import { fill } from '../object';
import { supportsNativeFetch } from '../supports';
import { timestampInSeconds } from '../time';
Expand Down Expand Up @@ -65,6 +66,15 @@ function instrumentFetch(): void {
};

triggerHandlers('fetch', erroredHandlerData);

if (isError(error) && error.stack === undefined) {
// NOTE: If you are a Sentry user, and you are seeing this stack frame,
// it means the error, that was caused by your fetch call did not
// have a stack trace, so the SDK backfilled the stack trace so
// you can see which fetch call failed.
error.stack = new Error(error.message).stack;
Copy link
Member

@AbhiPrasad AbhiPrasad Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to trim the frames here? I think we can set framesToPop to do this (error.framesToPop = 1).

}

// NOTE: If you are a Sentry user, and you are seeing this stack frame,
// it means the sentry.javascript SDK caught an error invoking your application code.
// This is expected behavior and NOT indicative of a bug with sentry.javascript.
Expand Down