fix: Update how wrapped functions are detected as native functions

[kamilogorek]

Ref: #1104
Based on: angular/zone.js#686

[mitsuhiko]

So I was looking at this before and I rejected doing it for a reason. I do not remember which one :(

Let me recollect my thoughts before I approve this.

[kamilogorek]

Sure, I'm not quite convinced if this is the best solution as well.
Opened PR so that we can discuss + run tests on SL.

[kamilogorek]

@benvinegar maybe you can chime in?

[MaxBittker]

eslint doesn't know who it's dealing with 😂

[jan-auer]

Apart from the general approach, shouldn't you invoke f.toString() instead of the prototype function in the tests?

[kamilogorek]

@jan-auer it's the same call when it comes to type coercion in JS

function foo () {
  return 'hello'
}

foo.toString()
// "function foo() {
//   return 'hello'
// }"

Function.prototype.toString.apply(foo)
// "function foo() {
//   return 'hello'
// }"

also:

foo.toString === Function.prototype.toString
// true

[jan-auer]

@kamilogorek I get that. But you're patching toString for those functions - I assume (?) - and then calling the non-patched version in tests.

[kamilogorek]

No, I patch F.prototype.toString :)

[jan-auer]

gotcha

[kamilogorek]

Approved via Slack