Skip to content

Conversation

HeroProtagonist
Copy link
Contributor

resolves #782

  • wrap sentry breadcrumbs in conditional to respect when _globalOptions.autoBreadcrumbs is falsy
  • update tests and docs to reflect disabling automatic breadcrumb collection

@kamilogorek
Copy link
Contributor

Thanks @HeroProtagonist! We also need to add sentry as one of the possible keys, to be used in a dictionary. Otherwise when you for example enable just console, it'll catch those sentry breadcrumbs as well now.

@HeroProtagonist
Copy link
Contributor Author

@kamilogorek Good catch! The changes I just added should address this.

Also, I am not sure this should be a shallow copy. Given that here the data is trimmed before it adds the sentry breadcrumb. I feel like the breadcrumbs are then off by 1 in the payload. If you agree I can have another PR to address this or add it to this one.

@kamilogorek
Copy link
Contributor

Thanks for your patience @HeroProtagonist, had some other things to work on lately.

I believe this shallow copy can stay as is, because trimming just affect the content of every breadcrumb, not total length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot disable automatic error breadcrumb collection

2 participants