fix: Make sure that document is available before reading location #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
suggested changes
Sep 15, 2017
vendor/TraceKit/tracekit.js
Outdated
| function getLocationHref() { | ||
| if (typeof document === 'undefined' || typeof document.location === 'undefined') | ||
| return ''; | ||
| if (document == null || document.location == null) return ''; |
There was a problem hiding this comment.
This seems problematic. What if document isn't defined? Won't accessing it to make a null comparison throw an exception?
Why not do:
if (typeof document === 'undefined' || document.location == null) return '';There was a problem hiding this comment.
Thanks for catching that. I completely forgot that document is just a reference to window.document and it has to obey the same rules as every other property.
kamilogorek
force-pushed
the
nonull-document
branch
from
f46b899 to
7670785
Compare
|
Updated |
benvinegar
approved these changes
Sep 18, 2017
|
Approved, but in the future, we should try to separate autoformatting changes from behavior changes. It's worth having separate PRs. |
kamilogorek
force-pushed
the
nonull-document
branch
from
7670785 to
ee9ffa2
Compare
|
I totally missed that @benvinegar, thanks for pointing that out. Fixed, merged code change only and updated PR here #1048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037
https://github.com/getsentry/raven-js/pull/1038/files?w=1#diff-05367d6a2553cabeca57c6ca111093fcR34 – this is the only real change, the rest is just prettify catching up with the rest of the files through precommit hook