Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Sep 10, 2024

Closes #579

Since we bundle the SDK into bundler-plugin-core, this PR migrates to using ServerRuntimeClient rather than the Node client because we don't need otel instrumentations and it reduces the bundle size by ~300kB. I copied and simplified the Node http transport because referencing the Node SDK at all caused bundling issues.

I also added a way to integration test the telemetry by setting a global which is used to store envelopes rather than sending them.

@timfish timfish marked this pull request as ready for review September 16, 2024 16:54
@timfish timfish requested review from Lms24 and lforst September 16, 2024 19:32
Copy link

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@lforst lforst merged commit be799ee into getsentry:main Sep 23, 2024
18 checks passed
@timfish timfish deleted the timfish/update-sentry-v8 branch September 23, 2024 10:22
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 3, 2024
| datasource | package             | from   | to     |
| ---------- | ------------------- | ------ | ------ |
| npm        | @sentry/vite-plugin | 2.22.4 | 2.22.5 |


## [v2.22.5](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2225)

-   fix: Ignore stderr output from git command ([#613](getsentry/sentry-javascript-bundler-plugins#613))
-   feat: Update Sentry telemetry to v8 ([#604](getsentry/sentry-javascript-bundler-plugins#604))
-   deps: Update `@sentry/cli` to `2.36.1` ([#609](getsentry/sentry-javascript-bundler-plugins#609))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update @sentry/node to v8

2 participants