chore(ci): Migrate danger workflow to v3 #4801
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts danger workflow from reusable workflow (v2) to composite action (v3). This is a breaking change that requires restructuring the job definition. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vaind
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
| 85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
| 17a0955 | 372.53 ms | 446.70 ms | 74.17 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| d217708 | 409.83 ms | 474.72 ms | 64.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| 85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
| 17a0955 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Danger workflow from v2 (reusable workflow) to v3 (composite action).
This PR correctly performs the migration by converting the job structure from a reusable workflow pattern to a composite action pattern, which is required for v3.
Changes
dangerjob fromuses: getsentry/github-workflows/.github/workflows/danger.yml@v2toruns-on: ubuntu-latestwithsteps: - uses: getsentry/github-workflows/danger@v3Why this is needed
PR #4760 (created by Dependabot) incorrectly attempted to migrate by just changing the version number from
@v2to@v3. However, v3 is a breaking change that converted Danger from a reusable workflow to a composite action, which requires a structural change to the workflow file.Benefits
Closes #4760
#skip-changelog
🤖 Generated with Claude Code