feat(android-distribution): Add build_configuration support and use snake_case for parsing responses #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse parsing - Add required buildConfiguration parameter to UpdateCheckParams - Update checkForUpdates to include build_configuration query parameter - Add debug logging to print full URL for debugging - Fix response parser to use correct backend format (update object instead of updateAvailable boolean) - Fix response parser to use snake_case field names to match backend API - Add toString methods to UpdateInfo and UpdateStatus classes for better debugging - Update all tests to match new response format 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
runningcode
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
|
runningcode
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| 9fbb112 | 359.71 ms | 421.85 ms | 62.14 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
romtsn
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Bug: API Validation Error Naming Mismatch
The validation error messages for missing fields still reference camelCase names like buildVersion, but the parser now expects snake_case names such as build_version. This mismatch can make debugging API response issues confusing.
sentry-android-distribution/src/main/java/io/sentry/android/distribution/UpdateResponseParser.kt#L66-L74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
build_configurationparameter in the Android distribution check-for-updates API#skip-changelog since this is for an unreleased feature